fix: upgraded versions.tf to include minor bumps from tpg v5 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apeabody
changed the title
smaftoul
reviewed
Oct 27, 2023
| @@ -20,11 +20,11 @@ terraform { | |||
|
|
|||
| google = { | |||
| source = "hashicorp/google" | |||
| version = ">= 3.53, < 5.0" | |||
| version = ">= 3.53, < 6" | |||
There was a problem hiding this comment.
Why would we block to version 6 ?
We don't know what's included in version 6 yet, and the module may still work.
Currently, it's "< 5.0" , and it's blocking terraform setups to update to provider v5, it's the only terraform google module that I use that does this.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days |
|
@g-awmalik are the test failures related or can we merge this? |
I just merged #123 cleanly, let's see if we now get a green run. If not, likely an incompatibility with TPG 5 which needs to be investigated. |
apeabody
approved these changes
Jan 8, 2024
|
@bharathkkb @g-awmalik all green now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.